[ https://issues.apache.org/jira/browse/HADOOP-10778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066406#comment-14066406 ]
Todd Lipcon commented on HADOOP-10778: -------------------------------------- Yea, agreed we have room to improve the native one. Just not sure it is worth the effort. Given that the patch no longer implements what's described in the JIRA title/description (or the discussion here) maybe better to close this as wontfix and open a new one entitled "improvements to pure java Crc32" which has the optimization and the benchmark? Or at the least update the description to add some note that says what the final patch is going to do? > Use NativeCrc32 only if it is faster > ------------------------------------ > > Key: HADOOP-10778 > URL: https://issues.apache.org/jira/browse/HADOOP-10778 > Project: Hadoop Common > Issue Type: Improvement > Components: util > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Attachments: c10778_20140702.patch, c10778_20140717.patch > > > From the benchmark post in [this > comment|https://issues.apache.org/jira/browse/HDFS-6560?focusedCommentId=14044060&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14044060], > NativeCrc32 is slower than java.util.zip.CRC32 for Java 7 and above when > bytesPerChecksum > 512. -- This message was sent by Atlassian JIRA (v6.2#6252)