[
https://issues.apache.org/jira/browse/HADOOP-10927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083893#comment-14083893
]
Stephen Chu commented on HADOOP-10927:
--------------------------------------
Hi Josh, thanks for fixing this.
Nit: In TestCredShell.java, the patch imports java.util.Collections but I don't
see it being used. Should it be removed?
Another useful improvement (though not necessary for this patch if you prefer
not to) would be to add "hadoop credential" to the main bin/hadoop usage. Right
now, when users execute bin/hadoop with no args to see the categories of
commands, credential does not show up. It'd be useful to let newer users know
of its existence.
> Ran `hadoop credential` expecting usage, got NPE instead
> --------------------------------------------------------
>
> Key: HADOOP-10927
> URL: https://issues.apache.org/jira/browse/HADOOP-10927
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Attachments: HADOOP-10927-1.diff, HADOOP-10927.diff
>
>
> {noformat}
> $ hadoop credential
> java.lang.NullPointerException
> at
> org.apache.hadoop.security.alias.CredentialShell.run(CredentialShell.java:67)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.security.alias.CredentialShell.main(CredentialShell.java:420)
> {noformat}
> Ran a no-arg version of {{hadoop credential}} expecting to get the usage/help
> message (like other commands act), and got the above exception instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
