[ 
https://issues.apache.org/jira/browse/HADOOP-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084654#comment-14084654
 ] 

Alejandro Abdelnur commented on HADOOP-10802:
---------------------------------------------

i've browsed the patch, the approach looks good. just not sure about the 
captured metrics.

IMO, we shouldn't capture per key metrics. knowing a key is request more than 
others, I don't think brings much. 

i would keep track of going below watermarks and refill requests and I would 
log the key names.



> Add metrics for KMS client and server encrypted key caches
> ----------------------------------------------------------
>
>                 Key: HADOOP-10802
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10802
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10802.WIP.patch
>
>
> HADOOP-10720 is adding KMS server and client caches for encrypted keys for 
> performance reasons. It would be good to add metrics to make sure that the 
> cache is working as expected, and to inform future dynamic cache sizing and 
> refilling policies.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to