[
https://issues.apache.org/jira/browse/HADOOP-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085083#comment-14085083
]
Andrew Wang commented on HADOOP-10886:
--------------------------------------
This looks generally okay, just had two comments:
- There was an unrelated import change in TestDistributedFileSystem
- Precondition checks are normally for either validating user arguments or the
equivalent of runtime assertions. I'd rather have just thrown an IOException in
DFSClient. It would have been good for the text to provide some guidance
regarding CRYPTO_CIPHER_SUITE and CRYPTO_CODEC_CLASSES_KEY so the user knows
what to fix.
Do you want to do this in a follow-on?
> CryptoCodec#getCodecclasses throws NPE when configurations not loaded.
> ----------------------------------------------------------------------
>
> Key: HADOOP-10886
> URL: https://issues.apache.org/jira/browse/HADOOP-10886
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0
>
> Attachments: HADOOP-10886.patch
>
>
> There are some test cases which will not load the xml defaults. In this case,
> CryptoCodec#getCodecclasses will fail with NPE.
> {noformat}
> java.lang.NullPointerException: null
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187)
> at com.google.common.base.Splitter.split(Splitter.java:371)
> at
> org.apache.hadoop.crypto.CryptoCodec.getCodecClasses(CryptoCodec.java:100)
> at
> org.apache.hadoop.crypto.CryptoCodec.getInstance(CryptoCodec.java:54)
> at
> org.apache.hadoop.crypto.CryptoCodec.getInstance(CryptoCodec.java:91)
> at
> org.apache.hadoop.crypto.TestCryptoStreamsForLocalFS.init(TestCryptoStreamsForLocalFS.java:53)
> {noformat}
> https://builds.apache.org/job/Hadoop-fs-encryption-nightly/71/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
