[
https://issues.apache.org/jira/browse/HADOOP-10940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097353#comment-14097353
]
Colin Patrick McCabe commented on HADOOP-10940:
-----------------------------------------------
bq. A bit confused. What else is using it besides the ipc Client itself?
OK, I think I see why this comment is there. SaslRpcClient is in the security
namespace, so that motivates making this class public. So the comment is
correct as-is. Sorry, my bad.
bq. It used to implicitly flush because the stream wasn't buffered (yet).
OK. And now that we've disabled Nagle, we definitely don't want to be sending
these small packets.
bq. \[flush discussion\]
The boolean + comment spew on each invocation just looks really ugly to me.
Can we make it an enum so it's self-documenting (NO_FLUSH, FLUSH)?
Or just create {{IpcStreams#flush}} which calls {{out.flush}}, and have callers
invoke this as needed.
> RPC client does no bounds checking of responses
> -----------------------------------------------
>
> Key: HADOOP-10940
> URL: https://issues.apache.org/jira/browse/HADOOP-10940
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HADOOP-10940.patch, HADOOP-10940.patch,
> HADOOP-10940.patch
>
>
> The rpc client does no bounds checking of server responses. In the case of
> communicating with an older and incompatible RPC, this may lead to OOM issues
> and leaking of resources.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
