[ 
https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110155#comment-14110155
 ] 

Tsuyoshi OZAWA commented on HADOOP-10365:
-----------------------------------------

Thanks for your reporting, [~yunsh]. As [~cmccabe] told me on HDFS-6902, it's 
better to use IOUtils.cleanup(LOG, outputStream) in final block. Do you mind 
updating a patch?

> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally 
> block
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10365
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10365.patch
>
>
> {code}
>     BufferedOutputStream outputStream = new BufferedOutputStream(
>         new FileOutputStream(outputFile));
> ...
>     outputStream.flush();
>     outputStream.close();
> {code}
> outputStream should be closed in finally block.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to