[ https://issues.apache.org/jira/browse/HADOOP-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119507#comment-14119507 ]
Hadoop QA commented on HADOOP-11044: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12666166/11044.patch2 against trunk revision 08a9ac7. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 javac{color}. The applied patch generated 1275 javac compiler warnings (more than the trunk's current 1263 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4637//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4637//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4637//console This message is automatically generated. > FileSystem counters can overflow for large number of readOps, largeReadOps, > writeOps > ------------------------------------------------------------------------------------ > > Key: HADOOP-11044 > URL: https://issues.apache.org/jira/browse/HADOOP-11044 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 2.5.0, 2.4.1 > Reporter: Swapnil Daingade > Priority: Minor > Attachments: 11044.patch2 > > > The org.apache.hadoop.fs.FileSystem.Statistics.StatisticsData class defines > readOps, largeReadOps, writeOps as int. Also the The > org.apache.hadoop.fs.FileSystem.Statistics class has methods like > getReadOps(), getLargeReadOps() and getWriteOps() that return int. These int > values can overflow if the exceed 2^31-1 showing negative values. It would be > nice if these can be changed to long. -- This message was sent by Atlassian JIRA (v6.3.4#6332)