[ https://issues.apache.org/jira/browse/HADOOP-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124797#comment-14124797 ]
Yongjun Zhang commented on HADOOP-11035: ---------------------------------------- Hi Zhihai, Thanks for addressing my comments. You added more comments than what I expected, but it looks good. One last minor thing in the new comments you added, would you please consider replacing the {{hadoop source root directory}} strings with {{<hadoopSrcRoot>}} in the comments? Thanks. > distcp on mr1(branch-1) fails with NPE using a short relative source path. > -------------------------------------------------------------------------- > > Key: HADOOP-11035 > URL: https://issues.apache.org/jira/browse/HADOOP-11035 > Project: Hadoop Common > Issue Type: Bug > Components: tools > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: HADOOP-11035.000.patch, HADOOP-11035.001.patch > > > distcp on mr1(branch-1) fails with NPE using a short relative source path. > The failure is at DistCp.java, makeRelative return null at the following code: > The parameters passed to makeRelative are not same format: > root is relative path and child.getPath() is a full path. > {code} > final String dst = makeRelative(root, child.getPath()); > {code} > The solution is > change root to full path to match child.getPath(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)