[ https://issues.apache.org/jira/browse/HADOOP-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150087#comment-14150087 ]
Jing Zhao commented on HADOOP-11130: ------------------------------------ The patch looks good to me. But as Allen suggested, we may also want to rename "LINUX_GET_ALL_USERS_CMD" to a less Linux specific name (maybe just remove the "LINUX_" prefix). Other than this +1. > NFS updateMaps OS check is reversed > ----------------------------------- > > Key: HADOOP-11130 > URL: https://issues.apache.org/jira/browse/HADOOP-11130 > Project: Hadoop Common > Issue Type: Bug > Components: nfs > Affects Versions: 2.2.0 > Reporter: Allen Wittenauer > Assignee: Brandon Li > Attachments: HADOOP-11130.001.patch > > > getent is fairly standard, dscl is not. Yet the code logic prefers dscl for > non-Linux platforms. This code should for OS X and use dscl and, if not, then > use getent. See comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)