[
https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206754#comment-14206754
]
Yongjun Zhang commented on HADOOP-11293:
----------------------------------------
Thanks a lot for your feedback Steve and Chris, and this is very helpful!
With the input you provided, I can understand the concerns you guys had. What
Steve suggested is similar to the mechanism that we deal with deprecated config
property, it helps to maintain backward compatibility, if we are going to make
the change. My thinking was, having this new API would at least allow any new
code not to couple with Shell. On the other hand, if we don't have the new API,
we will always have to couple with Shell for any new code.
One question for Steve: the patch I uploaded does a massive change in the
current code to replace calls to old APIs with calls to new API. If it's agreed
to introduce the new API, do you suggest to make the massive change altogether
like in my initial patch, or just to provide new APIs without replacing the
calls old API to address this jira?
Thanks again!
> Factor OSType out from Shell
> ----------------------------
>
> Key: HADOOP-11293
> URL: https://issues.apache.org/jira/browse/HADOOP-11293
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Yongjun Zhang
> Assignee: Yongjun Zhang
> Attachments: HADOOP-11293.001.patch
>
>
> Currently the code that detects the OS type is located in Shell.java. Code
> that need to check OS type refers to Shell, even if no other stuff of Shell
> is needed.
> I am proposing to refactor OSType out to its own class, so to make the
> OSType easier to access and the dependency cleaner.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
