[ https://issues.apache.org/jira/browse/HADOOP-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214901#comment-14214901 ]
Sangjin Lee commented on HADOOP-11309: -------------------------------------- [~jira.shegalov], thanks for the patch. It looks good to me. One minor nit: it might be good to enclose the last condition (the one that checks for the nested class) in parentheses for clarity: {code} || (canonicalName.length() > c.length() // nested && canonicalName.charAt(c.length()) == '$')) { {code} > System class pattern package.Foo should match package.Foo$Bar, too > ------------------------------------------------------------------ > > Key: HADOOP-11309 > URL: https://issues.apache.org/jira/browse/HADOOP-11309 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.5.0, 2.6.0 > Reporter: Gera Shegalov > Assignee: Gera Shegalov > Priority: Blocker > Attachments: HADOOP-11309.v01.patch > > > Currently when job classloader is enabled and the user specifies > {{package.Foo}} as a system class explicitly, nested classes are not > considered system classes. -- This message was sent by Atlassian JIRA (v6.3.4#6332)