[
https://issues.apache.org/jira/browse/HADOOP-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216559#comment-14216559
]
Yongjun Zhang commented on HADOOP-11312:
----------------------------------------
Thanks Andrew, I looked at the patch, it looks good.
One minor comment, TestKMS.java uses string ".ALL" at quite a few places (for
the key), And similarly ".MANAGEMENT", ".READ" etc appear in other code.
It'd be nice if we have this kind of string defined as constant in
KeyAuthorizationKeyProvider, in parallel with
{code}
public enum KeyOpType {
ALL, READ, MANAGEMENT, GENERATE_EEK, DECRYPT_EEK;
}
{code}
but it's ok to defer this to later.
Thanks.
> Fix unit tests to not use uppercase key names
> ---------------------------------------------
>
> Key: HADOOP-11312
> URL: https://issues.apache.org/jira/browse/HADOOP-11312
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.7.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hadoop-11312.001.patch, hadoop-11312.002.patch,
> hadoop-11312.003.patch
>
>
> After HADOOP-11311 uppercase key names aren't allowed, breaking some unit
> tests. Let's fix them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
