[ 
https://issues.apache.org/jira/browse/HADOOP-11211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219063#comment-14219063
 ] 

Yitong Zhou commented on HADOOP-11211:
--------------------------------------

[~jira.shegalov]: I'm a bit confused. If MAPREDUCE-6128 is not committed, then 
why my change in mapred-default.xml is a problem? Both of the two lines are 
added by me including the one regarding inner classes (not pulled in from any 
branch), I just feel it necessary to also add a comment about inner classes 
after I merged my change with it.

Do you actually mean that I should only add comments regarding to my fix in 
system classloader, and remove the line about inner classes?

> mapreduce.job.classloader.system.classes property behaves differently when 
> the exclusion and inclusion order is different
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11211
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11211
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: hudson
>            Reporter: Yitong Zhou
>            Assignee: Yitong Zhou
>             Fix For: hudson
>
>         Attachments: HADOOP-11211.patch
>
>
> If we want to include package foo.bar.* but exclude all sub packages named 
> foo.bar.tar.* in system classes, configuring 
> "mapreduce.job.classloader.system.classes=foo.bar.,-foo.bar.tar." won't work. 
> foo.bar.tar will still be pulled in. But if we change the order:
> "mapreduce.job.classloader.system.classes=-foo.bar.tar.,foo.bar.", then it 
> will work.
> This bug is due to the implementation of ApplicationClassLoaser#isSystemClass 
> in hadoop-common, where we simply return the matching result immediately when 
> the class name hits the first match (either positive or negative).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to