[ https://issues.apache.org/jira/browse/HADOOP-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maysam Yabandeh updated HADOOP-11301: ------------------------------------- Attachment: HADOOP-11301.v02.patch Thanks [~andrew.wang] and [~stack]. I am attaching the new patch that updates info cache whenever getAllMetrics is true. > [optionally] update jmx cache to drop old metrics > ------------------------------------------------- > > Key: HADOOP-11301 > URL: https://issues.apache.org/jira/browse/HADOOP-11301 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Maysam Yabandeh > Assignee: Maysam Yabandeh > Attachments: HADOOP-11301.v01.patch, HADOOP-11301.v02.patch > > > MetricsSourceAdapter::updateJmxCache() skips updating the info cache if no > new metric is added since last time: > {code} > int oldCacheSize = attrCache.size(); > int newCacheSize = updateAttrCache(); > if (oldCacheSize < newCacheSize) { > updateInfoCache(); > } > {code} > This behavior is not desirable in some applications. For example nntop > (HDFS-6982) reports the top users via jmx. The list is updated after each > report. The previously reported top users hence should be removed from the > cache upon each report request. > In our production run of nntop we made a change to ignore the size check and > always perform updateInfoCache. I am planning to submit a patch including > this change. The feature can be enabled by a configuration parameter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)