[
https://issues.apache.org/jira/browse/HADOOP-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221566#comment-14221566
]
Hadoop QA commented on HADOOP-11301:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12682976/HADOOP-11301.v03.patch
against trunk revision 233b61e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.metrics2.impl.TestMetricsSourceAdapter
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5112//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5112//console
This message is automatically generated.
> [optionally] update jmx cache to drop old metrics
> -------------------------------------------------
>
> Key: HADOOP-11301
> URL: https://issues.apache.org/jira/browse/HADOOP-11301
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Maysam Yabandeh
> Assignee: Maysam Yabandeh
> Attachments: HADOOP-11301.v01.patch, HADOOP-11301.v02.patch,
> HADOOP-11301.v03.patch
>
>
> MetricsSourceAdapter::updateJmxCache() skips updating the info cache if no
> new metric is added since last time:
> {code}
> int oldCacheSize = attrCache.size();
> int newCacheSize = updateAttrCache();
> if (oldCacheSize < newCacheSize) {
> updateInfoCache();
> }
> {code}
> This behavior is not desirable in some applications. For example nntop
> (HDFS-6982) reports the top users via jmx. The list is updated after each
> report. The previously reported top users hence should be removed from the
> cache upon each report request.
> In our production run of nntop we made a change to ignore the size check and
> always perform updateInfoCache. I am planning to submit a patch including
> this change. The feature can be enabled by a configuration parameter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
