[
https://issues.apache.org/jira/browse/HADOOP-11337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14226039#comment-14226039
]
Hadoop QA commented on HADOOP-11337:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12683790/HADOOP-11337.patch
against trunk revision 4a31611.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-kms.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5124//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5124//console
This message is automatically generated.
> KeyAuthorizationKeyProvider#doAccessCheck should throw exception if metadata
> for the specified key is null
> ----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11337
> URL: https://issues.apache.org/jira/browse/HADOOP-11337
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Dian Fu
> Attachments: HADOOP-11337.patch
>
>
> In {{KeyAuthorizationKeyProvider#getMetadata}}, if firstly call
> {{KeyAuthorizationKeyProvider#doAccessCheck}} to check if client has the
> permission to do this operation. However, if the metadata is null when
> {{KeyAuthorizationKeyProvider#doAccessCheck}} is called and becomes not null
> after {{KeyAuthorizationKeyProvider#doAccessCheck}} called, key based ACL
> check will be skipped. It should throw an exception if metadata is null in
> {{KeyAuthorizationKeyProvider#doAccessCheck}}.
> {code}
> public Metadata getMetadata(String name) throws IOException {
> doAccessCheck(name, KeyOpType.READ);
> return provider.getMetadata(name);
> }
> private void doAccessCheck(String keyName, KeyOpType opType) throws
> IOException {
> Metadata metadata = provider.getMetadata(keyName);
> if (metadata != null) {
> String aclName = metadata.getAttributes().get(KEY_ACL_NAME);
> checkAccess((aclName == null) ? keyName : aclName, getUser(), opType);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
