[
https://issues.apache.org/jira/browse/HADOOP-11341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227176#comment-14227176
]
Dian Fu commented on HADOOP-11341:
----------------------------------
Hi [~asuresh], this patch does can solve the issue reported in MAPREDUCE-6171.
This patch looks good, just a small issue is that the comments in
{{KMSACLs#hasAccessToKey}} may need to be updated.
{code}
// If No key acl defined for this key, check to see if
// there are key defaults configured for this operation
{code}
can to be updated to something like this:
{code}
// If No key acl defined for this operation of this key, check to see if
// there are key defaults configured for this operation
{code}
And I still have the following concerns:
# This patch changes the meaning of key ACL configuration. If one have already
had some key ACL configurations in a production cluster, he may need to update
these configurations when doing upgrade.
# If one configure {{default.key.acl.<OP-name>}} as {{*}}, then
{{key.acl.<key-name>.<OP-name>}} will become meaningless.
I'm not sure if this is what's expected by design of key ACL. If it's so, I'm
good to changing like this.
> Check if user is present in default key ACL if user does not have explicit
> key ACLS
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-11341
> URL: https://issues.apache.org/jira/browse/HADOOP-11341
> Project: Hadoop Common
> Issue Type: Bug
> Components: kms, security
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: HADOOP-11341.1.patch
>
>
> As reported by [~dian.fu] :
> Key based ACL in KMS is currently implemented as whitelist. So if I configure
> as follows in kms-acl.xml,
> {code}
> <property>
> <name>key.acl.testKey.DECRYPT_EEK</name>
> <value>testUser</value>
> </property>
> {code}, then only {{testUser}} user can do {{DECRYPT_EEK}} call on key
> {{testKey}}. If I want {{yarn}} user can also do {{DECRYPT_EEK}} call on
> {{testKey}} key, I need add {{yarn}} user to the above configuration value
> manually. This means that if I want to configure key based
> ACL({{DECRYPT_EEK}}) for {{some key}}, I need also add {{yarn}} user to
> configuration {{DECRYPT_EEK}} for that key. As I don't know if {{yarn}} user
> will later need to do {{DECRYPT_EEK}} for this key.. This is inconvenient and
> tricky.
> This can be alleviated by slightly modifying the key ACL logic in KMS first
> checks if the user, in this case {{yarn}}, is present in
> {{key.acl.<key-name>.<OP-name>}} list. And if not, then also check if the
> user is present in {{default.key.acl.<OP-name>}}. If yes, then grant access..
> else deny.
> Currently, {{default.key.acl.<OP-name>}} is consulted only if NO
> {{key.acl.<key-name>.<OP-name>}} is specified.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
