[ https://issues.apache.org/jira/browse/HADOOP-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247590#comment-14247590 ]
Haohui Mai commented on HADOOP-11387: ------------------------------------- LGTM. +1 pending jenkins. [~jeagles], do you have any comments? I'd like to commit it sooner rather than later as if blocks a clean Jenkins run. > Simplify NetUtils#canonicalizeHost() > ------------------------------------ > > Key: HADOOP-11387 > URL: https://issues.apache.org/jira/browse/HADOOP-11387 > Project: Hadoop Common > Issue Type: Bug > Reporter: Haohui Mai > Assignee: Li Lu > Attachments: HADOOP-11387-121514-1.patch, > HADOOP-11387-121514-2.patch, HADOOP-11387-121514.patch > > > Currently {{NetUtils#canonicalizeHost}} uses a {{ConcurrentHashMap}} to cache > the canonicalized hostname. > {code} > private static String canonicalizeHost(String host) { > // check if the host has already been canonicalized > String fqHost = canonicalizedHostCache.get(host); > if (fqHost == null) { > try { > fqHost = SecurityUtil.getByName(host).getHostName(); > // slight race condition, but won't hurt > canonicalizedHostCache.put(host, fqHost); > } catch (UnknownHostException e) { > fqHost = host; > } > } > return fqHost; > } > {code} > The code can be simplified using {{CacheMap}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)