[ 
https://issues.apache.org/jira/browse/HADOOP-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251275#comment-14251275
 ] 

Yi Liu edited comment on HADOOP-11424 at 12/18/14 6:24 AM:
-----------------------------------------------------------

Thanks Vinay for the comments.
I have not gone to see the detail reason on those jenkins servers why it 
failed, and also don't see this failure in my local env.

But whether the previous stream is closed, it can be covered by code review. I 
believe the code logic of that part is straight and simple. 
And it's not a good way to use {{lsof}}, it's not accurate and can be affected 
by other processes and there is no assertion too.


was (Author: hitliuyi):
I have not gone to see the detail reason on those jenkins servers why it 
failed, and also don't see this failure in my local env.

But whether the previous stream is closed, it can be covered by code review. I 
believe the code logic of that part is straight and simple. 
And it's not a good way to use {{lsof}}, it's not accurate and can be affected 
by other processes and there is no assertion too.

> Fix failure for TestOsSecureRandom
> ----------------------------------
>
>                 Key: HADOOP-11424
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11424
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HADOOP-11424.001.patch
>
>
> Recently I usually see failure of {{testOsSecureRandomSetConf}} in 
> TestOsSecureRandom.
> https://builds.apache.org/job/PreCommit-HADOOP-Build/5298//testReport/org.apache.hadoop.crypto.random/TestOsSecureRandom/testOsSecureRandomSetConf/
> {code}
> java.lang.Exception: test timed out after 120000 milliseconds
>       at java.io.FileInputStream.readBytes(Native Method)
>       at java.io.FileInputStream.read(FileInputStream.java:272)
>       at java.io.BufferedInputStream.read1(BufferedInputStream.java:273)
>       at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
>       at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:283)
>       at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:325)
>       at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:177)
>       at java.io.InputStreamReader.read(InputStreamReader.java:184)
>       at java.io.BufferedReader.fill(BufferedReader.java:154)
>       at java.io.BufferedReader.read1(BufferedReader.java:205)
>       at java.io.BufferedReader.read(BufferedReader.java:279)
>       at 
> org.apache.hadoop.util.Shell$ShellCommandExecutor.parseExecResult(Shell.java:735)
>       at org.apache.hadoop.util.Shell.runCommand(Shell.java:531)
>       at org.apache.hadoop.util.Shell.run(Shell.java:456)
>       at 
> org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:722)
>       at 
> org.apache.hadoop.crypto.random.TestOsSecureRandom.testOsSecureRandomSetConf(TestOsSecureRandom.java:149)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to