[ https://issues.apache.org/jira/browse/HADOOP-11414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254863#comment-14254863 ]
Tsuyoshi OZAWA commented on HADOOP-11414: ----------------------------------------- Thanks for your review, Akira. I found some points from your comment: * Throwable is overkill here. We should fix it as IOException. * Re-throwing IOException and catching it is straight forward to me. * In fact, unused imports is not related to this JIRA, but it's better to fix here. We can also fix the coding style here. v4 patch includes fixes above points. > Close of Reader should be enclosed in finally block in > FileBasedIPList#readLines() > ---------------------------------------------------------------------------------- > > Key: HADOOP-11414 > URL: https://issues.apache.org/jira/browse/HADOOP-11414 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: Ted Yu > Assignee: Tsuyoshi OZAWA > Priority: Minor > Attachments: HADOOP-11414.1.patch, HADOOP-11414.2.patch, > HADOOP-11414.3.patch, HADOOP-11414.4.patch > > > {code} > Reader fileReader = new InputStreamReader( > new FileInputStream(file), Charsets.UTF_8); > BufferedReader bufferedReader = new BufferedReader(fileReader); > List<String> lines = new ArrayList<String>(); > String line = null; > while ((line = bufferedReader.readLine()) != null) { > lines.add(line); > } > bufferedReader.close(); > {code} > Since bufferedReader.readLine() may throw IOE, so the close of bufferedReader > should be enclosed within finally block. -- This message was sent by Atlassian JIRA (v6.3.4#6332)