[ 
https://issues.apache.org/jira/browse/HADOOP-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280942#comment-14280942
 ] 

Sumit Kumar commented on HADOOP-10643:
--------------------------------------

[~ste...@apache.org] I'm assuming your concern is on this portion of the patch 
(as part of AbstractFileSystem.java):
{noformat}
-    // A file system implementation that requires authority must always
-    // specify default port
-    if (defaultPort < 0 && authorityNeeded) {
-      throw new HadoopIllegalArgumentException(
-          "FileSystem implementation error -  default port " + defaultPort
-              + " is not valid");
-    }
{noformat}

If so, s3's urls have a specific requirement that they don't contain any port 
(so defaultPort becomes -1 in this case) and they don't have any authority in 
the url as well. Does this work?

> Add NativeS3Fs that delgates calls from FileContext apis to native s3 fs 
> implementation
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10643
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10643
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs/s3
>    Affects Versions: 2.4.0
>            Reporter: Sumit Kumar
>            Assignee: Sumit Kumar
>         Attachments: HADOOP-10643.patch
>
>
> The new set of file system related apis (FileContext/AbstractFileSystem) 
> already support local filesytem, hdfs, viewfs) however they don't support 
> s3n. This patch is to add that support using configurations like
> fs.AbstractFileSystem.s3n.impl = org.apache.hadoop.fs.s3native.NativeS3Fs
> This patch however doesn't provide a new implementation, instead relies on 
> DelegateToFileSystem abstract class to delegate all calls from FileContext 
> apis for s3n to the NativeS3FileSystem implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to