[
https://issues.apache.org/jira/browse/HADOOP-11509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292728#comment-14292728
]
Chris Nauroth commented on HADOOP-11509:
----------------------------------------
Hi [~aw]. Based on my code review, I thought this change was OK for backwards
compatibility.
The first version would have been backwards-incompatible, because it would have
changed the precedence of -D arguments over -fs and -jt. (See 2 comments back
from me for more details.)
The committed version of the patch still moves the -D handling before the
handling of -libjars, -files and -archives. However, these are not analogous
to -fs and -jt. They do not map directly to an underlying user-facing
configuration property, so I expect the change in precedence isn't relevant.
While it is a change in behavior, I think the prior behavior can only be
considered a bug due to validateFiles caching a FileSystem with configuration
that didn't consider the -D arguments.
Please let me know if you disagree or if you think I missed something in the
review. The intent was not to put a backwards-incompatible change in branch-2.
> change parsing sequence in GenericOptionsParser to parse -D parameters first
> ----------------------------------------------------------------------------
>
> Key: HADOOP-11509
> URL: https://issues.apache.org/jira/browse/HADOOP-11509
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Fix For: 2.7.0
>
> Attachments: HADOOP-11509.1.patch, HADOOP-11509.2.patch
>
>
> In GenericOptionsParser, we need to parse -D parameter first. In that case,
> the user input parameter (through -D) can be set into configuration object
> earlier and used to process other parameters.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
