[
https://issues.apache.org/jira/browse/HADOOP-11514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294899#comment-14294899
]
Uma Maheswara Rao G commented on HADOOP-11514:
----------------------------------------------
Thanks all for the reviews. additionally I have one point to consider below.
{code}
+/**
+ * RawErasureCoder performs encoding/decoding given chunks of input data and
+ * generates chunks of outputs that corresponds to an erasure code scheme,
+ * like XOR and Reed-Solomon.
+ *
+ * RawErasureCoder is part of ErasureCodec framework, where ErasureCoder is
used
+ * to encode/decode a group of blocks (BlockGroup) according to the codec
+ * specific BlockGroup layout and logic.
+ *
+ * An ErasureCoder extracts chunks of data from the blocks and can employ
+ * various low level RawErasureCoders to perform encoding/decoding against
+ * the chunks.
+ *
+ * To distinguish from ErasureCoder, here RawErasureCoder is used to mean the
+ * low level constructs, since it only takes care of the math calculation with
+ * a group of byte buffers.
+ */
+public interface RawErasureCoder {
{code}
Seems like we may need to update this interface comments here. RawErasureCoder
is not really doing encoding/decoding by its interfaces declared. This sounds
to some helper interface for real encode/decoder interfaces.
But the comment says
{code}
performs encoding/decoding given chunks of input data and
+ * generates chunks of outputs that corresponds to an erasure code scheme,
+ * like XOR and Reed-Solomon.
{code}
So it may be good to update them?
> Raw Erasure Coder API for concrete encoding and decoding
> --------------------------------------------------------
>
> Key: HADOOP-11514
> URL: https://issues.apache.org/jira/browse/HADOOP-11514
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Fix For: HDFS-EC
>
> Attachments: HDFS-7353-v1.patch, HDFS-7353-v2.patch,
> HDFS-7353-v3.patch, HDFS-7353-v4.patch, HDFS-7353-v5.patch,
> HDFS-7353-v6.patch, HDFS-7353-v7.patch
>
>
> This is to abstract and define raw erasure coder API across different codes
> algorithms like RS, XOR and etc. Such API can be implemented by utilizing
> various library support, such as Intel ISA library and Jerasure library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
