[
https://issues.apache.org/jira/browse/HADOOP-11510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320689#comment-14320689
]
Chris Nauroth commented on HADOOP-11510:
----------------------------------------
I believe there is a backwards-compatibility problem in this patch.
{{AbstractFileSystem#truncate}} was declared abstract. That means that
external file system implementations that subclass {{AbstractFileSystem}} won't
be able to compile anymore, because they don't override the abstract method.
Traditionally, new file system operations are introduced with a base class
implementation that throws {{UnsupportedOperationException}} to avoid this
problem. I see this is how it was done for {{FileSystem#truncate}}, but not
for {{AbstractFileSystem#truncate}}.
[~hitliuyi], do you agree? If so, would you please file a new jira for a
follow-up change? Feel free to notify me. I'd be happy to do the code review.
Thanks!
> Expose truncate API via FileContext
> -----------------------------------
>
> Key: HADOOP-11510
> URL: https://issues.apache.org/jira/browse/HADOOP-11510
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Yi Liu
> Assignee: Yi Liu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11510.001.patch, HADOOP-11510.002.patch,
> HADOOP-11510.003.patch
>
>
> We also need to expose truncate API via {{org.apache.hadoop.fs.FileContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
