[ 
https://issues.apache.org/jira/browse/HADOOP-11603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322834#comment-14322834
 ] 

Tsuyoshi OZAWA commented on HADOOP-11603:
-----------------------------------------

[~brahmareddy] the term "snapshot" is not related to HDFS snapshot in 
MetricsSystemImpl:

{code}
  /**
   * Sample all the sources for a snapshot of metrics/tags
   * @return  the metrics buffer containing the snapshot
   */
  synchronized MetricsBuffer sampleMetrics() {
{code}

Is it OK to close this as "Not a problem"?

> Snapshot log can be removed #MetricsSystemImpl.java since all the services 
> will intialzed
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11603
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11603
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>            Priority: Minor
>         Attachments: HADOOP-11603.patch, defaultmetricIntialize-classes.JPG
>
>
> Namenode,DataNode,journalnode,ResourceManager, Nodemanager and historyservice 
> etc... will initialize DefaultMetricsSystem hence following log will be 
> logged for all the classes which is not correct.. since snapshot feature is 
> related to HDFS and this can be logged when snapshot is enabled.
> {code}
> LOG.info("Scheduled snapshot period at "+ period +" second(s).");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to