[
https://issues.apache.org/jira/browse/HADOOP-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323974#comment-14323974
]
Tsuyoshi OZAWA commented on HADOOP-11599:
-----------------------------------------
[~zxu] thank you for taking this JIRA.
{code}
+ @Test
+ public void testClientGetTimeout() throws IOException {
+ Configuration config = new Configuration();
+ if (CommonConfigurationKeys.IPC_CLIENT_PING_DEFAULT) {
{code}
This line looks typo instead of
config.get(getCommonConfigurationKeys.IPC_CLIENT_PING)? The condition always
returns true since CommonConfigurationKeys.IPC_CLIENT_PING_DEFAULT is true.
> Client#getTimeout should use IPC_CLIENT_PING_DEFAULT when IPC_CLIENT_PING_KEY
> is not configured.
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11599
> URL: https://issues.apache.org/jira/browse/HADOOP-11599
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Minor
> Attachments: HADOOP-11599.000.patch
>
>
> Client#getTimeout should use IPC_CLIENT_PING_DEFAULT instead of hard-coded
> value (true) when IPC_CLIENT_PING_KEY is not configured.
> {code}
> if (!conf.getBoolean(CommonConfigurationKeys.IPC_CLIENT_PING_KEY, true)) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
