[ 
https://issues.apache.org/jira/browse/HADOOP-9922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337537#comment-14337537
 ] 

Chris Nauroth commented on HADOOP-9922:
---------------------------------------

Thanks for the new patch, Kiran.  Thank you also for the extra cleanup of some 
of the warnings.

I still see one new warning in the 64-bit compile:

{code}
task.c(312): warning C4133: 'function' : incompatible types - from 'unsigned 
int *' to 'size_t *' 
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
{code}

Actually, it's not so much a new warning as a different kind of warning.  The 
existing code does have a warning on this line, but it's a different warning.  
I'd like to suggest that we drop the change in 
{{AddNodeManagerAndUserACEsToObject}} for now to avoid this.

I don't want to expand the scope of this jira to a large-scale cleanup of 
warnings.  I just wanted to confirm that: 1) the changes do not introduce new 
warnings for the 64-bit build and 2) the 32-bit build has no additional 
problematic warnings.  I think once we drop the change in 
{{AddNodeManagerAndUserACEsToObject}}, we'll meet that goal, and I'll be +1.

We can file a separate jira for a complete cleanup.  (FYI [~rusanu], these 
warnings appear to be related to the YARN security code.)

> hadoop windows native build will fail in 32 bit machine
> -------------------------------------------------------
>
>                 Key: HADOOP-9922
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9922
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, native
>    Affects Versions: 3.0.0, 2.1.1-beta
>            Reporter: Vinayakumar B
>            Assignee: Kiran Kumar M R
>         Attachments: HADOOP-9922-002.patch, HADOOP-9922-003.patch, 
> HADOOP-9922-004.patch, HADOOP-9922.patch
>
>
> Building Hadoop in windows 32 bit machine fails as native project is not 
> having Win32 configuration



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to