[
https://issues.apache.org/jira/browse/HADOOP-11392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341570#comment-14341570
]
Brahma Reddy Battula commented on HADOOP-11392:
-----------------------------------------------
Thanks a lot for your comment..
I agree with you.Yes, It's better to DEPRECATE as of now..will raise another
jira..? is that ok Or any other thoughts..?
> Use IOUtils.closeStream while closing streams in FileUtil.java
> --------------------------------------------------------------
>
> Key: HADOOP-11392
> URL: https://issues.apache.org/jira/browse/HADOOP-11392
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Brahma Reddy Battula
> Assignee: Brahma Reddy Battula
> Attachments: HADOOP-11392-1.patch, HADOOP-11392.patch
>
>
> Please check following code for same..
> {code}
> try {
> in = srcFS.open(src);
> out = dstFS.create(dst, overwrite);
> IOUtils.copyBytes(in, out, conf, true);
> } catch (IOException e) {
> IOUtils.closeStream(out);
> IOUtils.closeStream(in);
> throw e;
> }
> }
> {code}
> *can we use IOUtils.closeStream while closing the streams*
> {code}
> IOUtils.copyBytes(in, out, conf, false);
> if (addString!=null)
> out.write(addString.getBytes("UTF-8"));
>
> } finally {
> in.close();
> }
> }
> }
> } finally {
> out.close();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)