[ https://issues.apache.org/jira/browse/HADOOP-10027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348057#comment-14348057 ]
Hadoop QA commented on HADOOP-10027: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702397/HADOOP-10027.3.patch against trunk revision ded0200. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The following test timeouts occurred in hadoop-common-project/hadoop-common: org.apache.hadoop.io.compress.TestCodec Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5851//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5851//console This message is automatically generated. > *Compressor_deflateBytesDirect passes instance instead of jclass to > GetStaticObjectField > ---------------------------------------------------------------------------------------- > > Key: HADOOP-10027 > URL: https://issues.apache.org/jira/browse/HADOOP-10027 > Project: Hadoop Common > Issue Type: Bug > Components: native > Reporter: Eric Abbott > Assignee: Hui Zheng > Priority: Minor > Attachments: HADOOP-10027.1.patch, HADOOP-10027.2.patch, > HADOOP-10027.3.patch > > > http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c?view=markup > This pattern appears in all the native compressors. > // Get members of ZlibCompressor > jobject clazz = (*env)->GetStaticObjectField(env, this, > ZlibCompressor_clazz); > The 2nd argument to GetStaticObjectField is supposed to be a jclass, not a > jobject. Adding the JVM param -Xcheck:jni will cause "FATAL ERROR in native > method: JNI received a class argument that is not a class" and a core dump > such as the following. > (gdb) > #0 0x00007f02e4aef8a5 in raise () from /lib64/libc.so.6 > #1 0x00007f02e4af1085 in abort () from /lib64/libc.so.6 > #2 0x00007f02e45bd727 in os::abort(bool) () from > /opt/jdk1.6.0_31/jre/lib/amd64/server/libjvm.so > #3 0x00007f02e43cec63 in jniCheck::validate_class(JavaThread*, _jclass*, > bool) () from /opt/jdk1.6.0_31/jre/lib/amd64/server/libjvm.so > #4 0x00007f02e43ea669 in checked_jni_GetStaticObjectField () from > /opt/jdk1.6.0_31/jre/lib/amd64/server/libjvm.so > #5 0x00007f02d38eaf79 in > Java_org_apache_hadoop_io_compress_zlib_ZlibCompressor_deflateBytesDirect () > from /usr/lib/hadoop/lib/native/libhadoop.so.1.0.0 > In addition, that clazz object is only used for synchronization. In the case > of the native method _deflateBytesDirect, the result is a class wide lock > used to access the instance field uncompressed_direct_buf. Perhaps using the > instance as the sync point is more appropriate? -- This message was sent by Atlassian JIRA (v6.3.4#6332)