[ https://issues.apache.org/jira/browse/HADOOP-11659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14354350#comment-14354350 ]
Akira AJISAKA commented on HADOOP-11659: ---------------------------------------- Minor nit: Would you fix the indent also? I'm +1 if that is addressed. {code} + if ( fs == map.get(key)) { map.remove(key); toAutoClose.remove(key); } // remove 2 whitespaces before "}" {code} [~jira.shegalov] do you have any comments? > o.a.h.fs.FileSystem.Cache#remove should use a single hash map lookup > -------------------------------------------------------------------- > > Key: HADOOP-11659 > URL: https://issues.apache.org/jira/browse/HADOOP-11659 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 2.6.0 > Reporter: Gera Shegalov > Assignee: Brahma Reddy Battula > Priority: Minor > Attachments: HADOOP-11659-002.patch, HADOOP-11659.patch > > > The method looks up the same key in the same hash map potentially 3 times > {code} > if (map.containsKey(key) && fs == map.get(key)) { > map.remove(key) > {code} > Instead it could do a single lookup > {code} > FileSystem cachedFs = map.remove(key); > {code} > and then test cachedFs == fs or something else. -- This message was sent by Atlassian JIRA (v6.3.4#6332)