[ https://issues.apache.org/jira/browse/HADOOP-11709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370771#comment-14370771 ]
Ajith S commented on HADOOP-11709: ---------------------------------- test cases are not required as no new scenario is introduced, the existing test cases passing is enough > Time.NANOSECONDS_PER_MILLISECOND - use class level final constant instead of > method variable > --------------------------------------------------------------------------------------------- > > Key: HADOOP-11709 > URL: https://issues.apache.org/jira/browse/HADOOP-11709 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Ajith S > Assignee: Ajith S > Priority: Trivial > Labels: beginner, newbie > Attachments: 001-HDFS-7919.patch > > > NANOSECONDS_PER_MILLISECOND constant can be moved to class level instead of > creating it in each method call. > {code} > org.apache.hadoop.util.Time.java > public static long monotonicNow() { > final long NANOSECONDS_PER_MILLISECOND = 1000000; > return System.nanoTime() / NANOSECONDS_PER_MILLISECOND; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)