[
https://issues.apache.org/jira/browse/HADOOP-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379229#comment-14379229
]
Hadoop QA commented on HADOOP-11741:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12707112/HADOOP-11741.002.patch
against trunk revision 53a28af.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ipc.TestRPCWaitForProxy
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5991//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5991//console
This message is automatically generated.
> Add LOG.isDebugEnabled() guard for some LOG.debug(..)
> -----------------------------------------------------
>
> Key: HADOOP-11741
> URL: https://issues.apache.org/jira/browse/HADOOP-11741
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Walter Su
> Assignee: Walter Su
> Attachments: HADOOP-11741.001.patch, HADOOP-11741.002.patch
>
>
> {{isDebugEnabled()}} is optional. But when there are :
> 1. lots of concatenating Strings
> 2. complicated function calls
> in the arguments, {{LOG.debug(..)}} should be guarded with
> {{LOG.isDebugEnabled()}} to avoid unnecessary arguments evaluation and impove
> performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
