[ 
https://issues.apache.org/jira/browse/HADOOP-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385736#comment-14385736
 ] 

Steve Loughran commented on HADOOP-9805:
----------------------------------------

LGTM. Chris: what do you think?

> Refactor RawLocalFileSystem#rename for improved testability.
> ------------------------------------------------------------
>
>                 Key: HADOOP-9805
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9805
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, test
>    Affects Versions: 3.0.0, 1-win, 1.3.0, 2.1.1-beta
>            Reporter: Chris Nauroth
>            Assignee: Jean-Pierre Matsumoto
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-9805.001.patch
>
>
> {{RawLocalFileSystem#rename}} contains fallback logic to provide POSIX rename 
> behavior on platforms where {{java.io.File#renameTo}} fails.  The method 
> returns early if {{java.io.File#renameTo}} succeeds, so test runs may not 
> cover the fallback logic depending on the platform.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to