[ https://issues.apache.org/jira/browse/HADOOP-11660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386921#comment-14386921 ]
Hadoop QA commented on HADOOP-11660: ------------------------------------ {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708163/jira-11660.patch against trunk revision ae3e8c6. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6025//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6025//console This message is automatically generated. > Add support for hardware crc on ARM aarch64 architecture > -------------------------------------------------------- > > Key: HADOOP-11660 > URL: https://issues.apache.org/jira/browse/HADOOP-11660 > Project: Hadoop Common > Issue Type: Improvement > Components: native > Affects Versions: 3.0.0 > Environment: ARM aarch64 development platform > Reporter: Edward Nevill > Assignee: Edward Nevill > Priority: Minor > Labels: performance > Attachments: jira-11660.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > This patch adds support for hardware crc for ARM's new 64 bit architecture > The patch is completely conditionalized on __aarch64__ > I have only added support for the non pipelined version as I benchmarked the > pipelined version on aarch64 and it showed no performance improvement. > The aarch64 version supports both Castagnoli and Zlib CRCs as both of these > are supported on ARM aarch64 hardwre. > To benchmark this I modified the test_bulk_crc32 test to print out the time > taken to CRC a 1MB dataset 1000 times. > Before: > CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 2.55 > CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 2.55 > After: > CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 0.57 > CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 0.57 > So this represents a 5X performance improvement on raw CRC calculation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)