[
https://issues.apache.org/jira/browse/HADOOP-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487096#comment-14487096
]
Kai Zheng commented on HADOOP-11818:
------------------------------------
Hi [~rakeshr],
Thanks for reporting this. The patch looks great. I noticed another issue not
relevant to the patch, would you fix it by the way?
In {{RSErasureDecoder}} and {{RSErasureEncoder}}, it has comments like below,
which should be corrected. Thanks.
{code}
It implements {@link ErasureDecoder}.
{code}
> Minor improvements for erasurecode classes
> ------------------------------------------
>
> Key: HADOOP-11818
> URL: https://issues.apache.org/jira/browse/HADOOP-11818
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: io
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HADOOP-11818-001.patch
>
>
> Following are few observations while going through the {{erasurecode}}
> classes.
> \\
> - Use {{org.slf4j.Logger}} instead of {{org.apache.commons.logging.Log}}
> - {{RSErasureDecoder}}, {{RSErasureEncoder}}, {{RSUtil}} missing Apache
> License header.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
