[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498660#comment-14498660
]
Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------
A few things:
a) It'd be great if HADOOP-11778 was committed as well. This updates the
checkstyle plugin so that it doesn't NPE on our code base in certain
conditions, at least on trunk. It doesn't *break* the plugin, but it does mean
the results may not be 100% accurate.
b) We need to be aware that shellcheck isn't installed on the jenkins boxes
yet. This means the shellcheck tests won't execute until that's rectified.
(That plugin shouldn't error, however, since the code does try to see if it is
installed first.)
c) We'll likely need to commit to branch-2 anyway if we want the patch branch
detection code to work. I don't know how jenkins actually uses test-patch.sh,
but this code does *not* switch the branch back to trunk after it runs on
another branch. This might very well be a bug, now that I think about it more.
> rewrite test-patch.sh
> ---------------------
>
> Key: HADOOP-11746
> URL: https://issues.apache.org/jira/browse/HADOOP-11746
> Project: Hadoop Common
> Issue Type: Test
> Components: build, test
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
> HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch,
> HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch,
> HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
> HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch,
> HADOOP-11746-15.patch, HADOOP-11746-16.patch
>
>
> This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
