[ https://issues.apache.org/jira/browse/HADOOP-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506620#comment-14506620 ]
Hadoop QA commented on HADOOP-11848: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 5m 43s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | javac | 7m 27s | There were no new javac warning messages. | | {color:green}+1{color} | release audit | 0m 19s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | install | 1m 38s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | common tests | 21m 43s | Tests passed in hadoop-common. | | | | 37m 31s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12727147/HADOOP-11848.001.patch | | Optional Tests | javac unit | | git revision | trunk / 6f8003d | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6145/artifact/patchprocess/testrun_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6145/testReport/ | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6145//console | This message was automatically generated. > Incorrect arguments to sizeof in DomainSocket.c > ----------------------------------------------- > > Key: HADOOP-11848 > URL: https://issues.apache.org/jira/browse/HADOOP-11848 > Project: Hadoop Common > Issue Type: Bug > Components: native > Affects Versions: 2.6.0 > Reporter: Malcolm Kavalsky > Assignee: Malcolm Kavalsky > Labels: native > Fix For: 2.6.1 > > Attachments: HADOOP-11848.001.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > Length of buffer to be zeroed using sizeof , should not use the address of > the structure rather the structure itself. > DomainSocket.c line 156 > Replace current: > memset(&addr,0,sizeof,(&addr)); > With: > memset(&addr, 0, sizeof(addr)); -- This message was sent by Atlassian JIRA (v6.3.4#6332)