[ https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507573#comment-14507573 ]
Wangda Tan commented on HADOOP-11746: ------------------------------------- Thanks [~aw] for this great work, adding checkstyle/whitespace check is helpful, but I think it's better to indicate it's a -0/+0 instead of "-1". Different from other checks like findbugs/javac WARNINGs/test-not-include, they're best-to-have minor format suggestions. An example is: https://issues.apache.org/jira/browse/YARN-3413?focusedCommentId=14507511&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14507511. Thoughts? > rewrite test-patch.sh > --------------------- > > Key: HADOOP-11746 > URL: https://issues.apache.org/jira/browse/HADOOP-11746 > Project: Hadoop Common > Issue Type: Test > Components: build, test > Affects Versions: 3.0.0 > Reporter: Allen Wittenauer > Assignee: Allen Wittenauer > Fix For: 2.8.0 > > Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch, > HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch, > HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch, > HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch, > HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch, > HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch, > HADOOP-11746-18.patch, HADOOP-11746-19.patch, HADOOP-11746-20.patch, > HADOOP-11746-21.branch-2.patch, HADOOP-11746-21.patch > > > This code is bad and you should feel bad. -- This message was sent by Atlassian JIRA (v6.3.4#6332)