[ https://issues.apache.org/jira/browse/HADOOP-11772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508468#comment-14508468 ]
Hadoop QA commented on HADOOP-11772: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 38s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | javac | 7m 30s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 3m 57s | The applied patch generated 2 additional checkstyle issues. | | {color:green}+1{color} | install | 1m 34s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 40s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:red}-1{color} | common tests | 36m 50s | Tests failed in hadoop-common. | | | | 76m 40s | | \\ \\ || Reason || Tests || | Timed out tests | org.apache.hadoop.http.TestHttpCookieFlag | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12727523/HADOOP-11772-003.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / a100be6 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/6161/artifact/patchprocess/checkstyle-result-diff.txt | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6161/artifact/patchprocess/testrun_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6161/testReport/ | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6161//console | This message was automatically generated. > RPC Invoker relies on static ClientCache which has synchronized(this) blocks > ---------------------------------------------------------------------------- > > Key: HADOOP-11772 > URL: https://issues.apache.org/jira/browse/HADOOP-11772 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc, performance > Reporter: Gopal V > Assignee: Akira AJISAKA > Attachments: HADOOP-11772-001.patch, HADOOP-11772-002.patch, > HADOOP-11772-003.patch, HADOOP-11772-wip-001.patch, > HADOOP-11772-wip-002.patch, after-ipc-fix.png, dfs-sync-ipc.png, > sync-client-bt.png, sync-client-threads.png > > > {code} > private static ClientCache CLIENTS=new ClientCache(); > ... > this.client = CLIENTS.getClient(conf, factory); > {code} > Meanwhile in ClientCache > {code} > public synchronized Client getClient(Configuration conf, > SocketFactory factory, Class<? extends Writable> valueClass) { > ... > Client client = clients.get(factory); > if (client == null) { > client = new Client(valueClass, conf, factory); > clients.put(factory, client); > } else { > client.incCount(); > } > {code} > All invokers end up calling these methods, resulting in IPC clients choking > up. > !sync-client-threads.png! > !sync-client-bt.png! > !dfs-sync-ipc.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)