[
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Naganarasimha G R updated HADOOP-11866:
---------------------------------------
Attachment: HADOOP-11866.20150423-1.patch
Thanks for the comments [~wheat9] & [~busbey],
+1 for suggestion in the output file, as many like me might not be aware of
{{git apply --whitespace=fix}} option,
IMO If it was small number of white space issues then {{git apply
--whitespace=fix}} would be little more work than manually correcting, so i
would prefer to have line numbers to be printed so that i can do the required
changes faster.
[~busbey], IMHO just the filename is not so useful, file name and followed
with the actual lines number within that file would be useful else line numbers
based on the patch would be better. IMO later approach was simpler and better,
hence updated the patch with the later approach and header for checkstyle
output
> increase readability of the output of white space and checkstyle script
> -----------------------------------------------------------------------
>
> Key: HADOOP-11866
> URL: https://issues.apache.org/jira/browse/HADOOP-11866
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Minor
> Attachments: HADOOP-11866.20150422-1.patch,
> HADOOP-11866.20150423-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces
> but doesn't inform patch line number. Without this report output will not be
> of much help as in most cases it reports blank lines. Also for the first
> timers it would be difficult to understand the output check style script
> hence adding an header
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
