[
https://issues.apache.org/jira/browse/HADOOP-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512840#comment-14512840
]
Allen Wittenauer commented on HADOOP-11866:
-------------------------------------------
A few things:
a) shellcheck is complaining about the multi-line echos redirecting to a file.
It's generally preferred now to group them into a subshell and then redirect
the shell. But I think the message should really be directed to the patch
author in the footer table via an add_footer_table call.
b) I think it'd be worthwhile to do quite a bit more hacking on the checkstyle
module. When I looked at checkstyle, I was clearly asleep. There are actually
quite a few things we can do to make this much more usable:
* Switch from the aggregate report to a per module report. (This should also
reduce the run time and it makes the other things we should do easier.)
* Rip out the python code. We aren't going to need it anymore.
* Add -Dcheckstyle.output.file=blah and -Dcheckstyle.output.format=plain to
both mvn command lines, where blah is the file we want for that module for that
part of the run. Strip a large chunk of the leading pathname (${BASEDIR} at a
minimum, but probably all of ${BASEDIR} and modulename, since the file is
already broken up by module).
* Now we can perform diffs and such like we do for some of the other tests (see
shellcheck, for example). This has the advantage of pointing out the exact
error on the exact line that broke without having to deal with giant HTML
files.
> increase readability of the output of white space and checkstyle script
> -----------------------------------------------------------------------
>
> Key: HADOOP-11866
> URL: https://issues.apache.org/jira/browse/HADOOP-11866
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Minor
> Attachments: HADOOP-11866.20150422-1.patch,
> HADOOP-11866.20150423-1.patch
>
>
> HADOOP-11746 supports listing of the lines which has trailing white spaces
> but doesn't inform patch line number. Without this report output will not be
> of much help as in most cases it reports blank lines. Also for the first
> timers it would be difficult to understand the output check style script
> hence adding an header
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
