[
https://issues.apache.org/jira/browse/HADOOP-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515118#comment-14515118
]
Chris Nauroth commented on HADOOP-11778:
----------------------------------------
Thank you for the patch, Allen.
# Following Steve's suggestion, I found that it works to remove the definition
of the {{maven-checkstyle-plugin.version}} property from
hadoop-project/pom.xml, move it to the root pom.xml, and then have both
hadoop-project/pom.xml and pom.xml refer to the version using that property.
It does require a full {{mvn install}} from the root of the source tree after
the change to make it work when running checkstyle from within sub-modules, but
that's true no matter how we do this change.
# After the change, I could not run {{mvn checkstyle:checkstyle}} in the
hadoop-hdfs sub-module. After some digging, I found out that the
RedundantThrows checkstyle module was removed from the newer version. We need
to remove it from hadoop-hdfs/dev-support/checkstyle.xml. After I did that, it
worked. More details on that Checkstyle change are here:
https://github.com/checkstyle/checkstyle/issues/473
I can't find a clear statement of whether or not there is a different module
that replaces it. Maybe these rules are just folded into default configuration
now?
> Update checkstyle
> -----------------
>
> Key: HADOOP-11778
> URL: https://issues.apache.org/jira/browse/HADOOP-11778
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Attachments: HADOOP-11778.000.patch
>
>
> We should update checkstyle so that mvn checkstyle:checkstyle-aggregate
> doesn't NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
