[ 
https://issues.apache.org/jira/browse/HADOOP-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14535968#comment-14535968
 ] 

Zoran Dimitrijevic commented on HADOOP-1540:
--------------------------------------------

please fix: "The patch has 3 line(s) that end in whitespace. Use git apply 
--whitespace=fix."

RegexCopyFilter constructor is currently reading from a file which is not 
ideal. It would be nicer if there is an init method and keep constructor only 
reading filename from the config. But, again, this might not be Hadoop style, 
and reading a file in constructor might be ok.

Other than that, LGTM.

> distcp should support an exclude list
> -------------------------------------
>
>                 Key: HADOOP-1540
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1540
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 2.6.0
>            Reporter: Senthil Subramanian
>            Assignee: Rich Haase
>            Priority: Minor
>              Labels: BB2015-05-TBR, patch
>         Attachments: HADOOP-1540.007.patch
>
>
> There should be a way to ignore specific paths (eg: those that have already 
> been copied over under the current srcPath). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to