[ https://issues.apache.org/jira/browse/HADOOP-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541262#comment-14541262 ]
Hadoop QA commented on HADOOP-11966: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 56s | Pre-patch branch-2 compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 5m 49s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck (v0.3.3) issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 18s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | common tests | 23m 8s | Tests passed in hadoop-common. | | {color:red}-1{color} | hdfs tests | 165m 18s | Tests failed in hadoop-hdfs. | | | | 221m 10s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.hdfs.server.datanode.TestDataNodeMetrics | | | hadoop.tracing.TestTraceAdmin | | | hadoop.tools.TestHdfsConfigFields | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12732413/HADOOP-11966-branch-2.001.patch | | Optional Tests | javadoc javac unit shellcheck | | git revision | branch-2 / d5755ba | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6677/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6677/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6677/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6677/console | This message was automatically generated. > Variable cygwin is undefined in hadoop-config.sh when executed through > hadoop-daemon.sh. > ---------------------------------------------------------------------------------------- > > Key: HADOOP-11966 > URL: https://issues.apache.org/jira/browse/HADOOP-11966 > Project: Hadoop Common > Issue Type: Bug > Components: scripts > Affects Versions: 2.7.0 > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Critical > Attachments: HADOOP-11966-branch-2.001.patch > > > HADOOP-11464 reinstated support for running the bash scripts through Cygwin. > The logic involves setting a {{cygwin}} flag variable to indicate if the > script is executing through Cygwin. The flag is set in all of the > interactive scripts: {{hadoop}}, {{hdfs}}, {{yarn}} and {{mapred}}. The flag > is not set through hadoop-daemon.sh though. This can cause an erroneous > overwrite of {{HADOOP_HOME}} and {{JAVA_LIBRARY_PATH}} inside > hadoop-config.sh. -- This message was sent by Atlassian JIRA (v6.3.4#6332)