[ https://issues.apache.org/jira/browse/HADOOP-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544309#comment-14544309 ]
Chris Nauroth commented on HADOOP-11960: ---------------------------------------- Hello [~dchickabasapa]. This patch is looking pretty good. I verified the tests running against the live service. Here are a few minor comments. # Please add the standard Apache license header to the top of {{TestNativeAzureFileSystemClientLogging}}. That will fix the release audit warning from the last Jenkins run. # To satisfy checkstyle, please change this... {code} OperationContext.setLoggingEnabledByDefault(sessionConfiguration.getBoolean (KEY_ENABLE_STORAGE_CLIENT_LOGGING, false)); {code} ...to this... {code} OperationContext.setLoggingEnabledByDefault(sessionConfiguration.getBoolean( KEY_ENABLE_STORAGE_CLIENT_LOGGING, false)); {code} # Please try to remove trailing whitespace before uploading the next patch. If there is a problem, I'll handle it at commit time using {{git apply --whitespace=fix}}. For future patches, please take a look at the section of the contribution wiki about naming standards for patch files. https://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch > Enable Azure-Storage Client Side logging. > ----------------------------------------- > > Key: HADOOP-11960 > URL: https://issues.apache.org/jira/browse/HADOOP-11960 > Project: Hadoop Common > Issue Type: Improvement > Components: tools > Reporter: Dushyanth > Assignee: Dushyanth > Attachments: > 0001-HADOOP-945-Enabling-WASB-Azure-Storage-Client-side-l.patch > > > AzureStorageExceptions currently are logged as part of the WAB code which > often is not too informative. AzureStorage SDK supports client side logging > that can be enabled that logs relevant information w.r.t request made from > the Storage client. > This JIRA is created to enable Azure Storage Client Side logging at the Job > submission level. User should be able to configure Client Side logging on a > Per Job bases. -- This message was sent by Atlassian JIRA (v6.3.4#6332)