[ https://issues.apache.org/jira/browse/HADOOP-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544831#comment-14544831 ]
Hadoop QA commented on HADOOP-11970: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 15m 6s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 7 new or modified test files. | | {color:green}+1{color} | javac | 7m 49s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 45s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 3m 38s | The applied patch generated 3 new checkstyle issues (total was 850, now 848). | | {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 33s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 5m 44s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | common tests | 23m 19s | Tests passed in hadoop-common. | | {color:green}+1{color} | yarn tests | 6m 3s | Tests passed in hadoop-yarn-server-nodemanager. | | {color:red}-1{color} | hdfs tests | 167m 13s | Tests failed in hadoop-hdfs. | | | | 241m 28s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.tools.TestHdfsConfigFields | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12732983/HADOOP-11970.2.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 09fe16f | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/6696/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6696/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6696/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6696/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6696/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6696/console | This message was automatically generated. > Replace uses of ThreadLocal<Random> with ThreadLocalRandom on branches that > are JDK7+ > ------------------------------------------------------------------------------------- > > Key: HADOOP-11970 > URL: https://issues.apache.org/jira/browse/HADOOP-11970 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Sean Busbey > Assignee: Sean Busbey > Attachments: HADOOP-11970.1.patch, HADOOP-11970.2.patch > > > ThreadLocalRandom should be used when available in place of > ThreadLocal<Random>. For JDK7 the difference is minimal, but JDK8 starts > including optimizations for ThreadLocalRandom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)