[ https://issues.apache.org/jira/browse/HADOOP-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akira AJISAKA updated HADOOP-12018: ----------------------------------- Description: If the patch edits a file includes CR+LF and created by "git diff --no-prefix", smart-apply-patch.sh fails to patch. This is because https://builds.apache.org/job/PreCommit-HADOOP-Build/6800/console fails. smart-apply-patch.sh checks if the patch is created by "git diff" or "patch", however, if a patch is created by "git diff --no-prefix", smart-apply-patch.sh detects the patch is created by "patch" command. A workaround is to use "git diff" for creating patch if a file includes CR+LF is edited. > smart-apply-patch.sh fails if the patch edits CR+LF files and is created by > 'git diff --no-prefix' > -------------------------------------------------------------------------------------------------- > > Key: HADOOP-12018 > URL: https://issues.apache.org/jira/browse/HADOOP-12018 > Project: Hadoop Common > Issue Type: Bug > Components: build > Reporter: Akira AJISAKA > Priority: Minor > > If the patch edits a file includes CR+LF and created by "git diff > --no-prefix", smart-apply-patch.sh fails to patch. This is because > https://builds.apache.org/job/PreCommit-HADOOP-Build/6800/console fails. > smart-apply-patch.sh checks if the patch is created by "git diff" or "patch", > however, if a patch is created by "git diff --no-prefix", > smart-apply-patch.sh detects the patch is created by "patch" command. > A workaround is to use "git diff" for creating patch if a file includes CR+LF > is edited. -- This message was sent by Atlassian JIRA (v6.3.4#6332)