[ https://issues.apache.org/jira/browse/HADOOP-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
kanaka kumar avvaru reassigned HADOOP-9995: ------------------------------------------- Assignee: kanaka kumar avvaru > Consistent log severity level guards and statements > ---------------------------------------------------- > > Key: HADOOP-9995 > URL: https://issues.apache.org/jira/browse/HADOOP-9995 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Jackie Chang > Assignee: kanaka kumar avvaru > Priority: Minor > Labels: BB2015-05-TBR > Attachments: HADOOP-9995.patch > > > Developers use logs to do in-house debugging. These log statements are later > demoted to less severe levels and usually are guarded by their matching > severity levels. However, we do see inconsistencies in trunk. A log statement > like > {code} > if (LOG.isDebugEnabled()) { > LOG.info("Assigned container (" + allocated + ") " > {code} > doesn't make much sense because the log message is actually only printed out > in DEBUG-level. We do see previous issues tried to correct this > inconsistency. I am proposing a comprehensive correction over trunk. > Doug Cutting pointed it out in HADOOP-312: > https://issues.apache.org/jira/browse/HADOOP-312?focusedCommentId=12429498&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12429498 > HDFS-1611 also corrected this inconsistency. > This could have been avoided by switching from log4j to slf4j's {} format > like CASSANDRA-625 (2010/3) and ZOOKEEPER-850 (2012/1), which gives cleaner > code and slightly higher performance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)