[ https://issues.apache.org/jira/browse/HADOOP-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570489#comment-14570489 ]
Hadoop QA commented on HADOOP-11924: ------------------------------------ \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 36s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 33s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 8s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 36s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 50s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | common tests | 23m 25s | Tests passed in hadoop-common. | | | | 62m 45s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12737103/HADOOP-11924.002.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 54f83d9 | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6903/artifact/patchprocess/testrun_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6903/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6903/console | This message was automatically generated. > Tolerate JDK-8047340-related exceptions in Shell#isSetSidAvailable preventing > class init > ---------------------------------------------------------------------------------------- > > Key: HADOOP-11924 > URL: https://issues.apache.org/jira/browse/HADOOP-11924 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.8.0 > Reporter: Gera Shegalov > Assignee: Tsuyoshi Ozawa > Attachments: HADOOP-11924.001.patch, HADOOP-11924.002.patch > > > Address the root cause of HADOOP-11916 per > https://issues.apache.org/jira/browse/HADOOP-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528009#comment-14528009 > {quote} > JDK-8047340 explicitly calls out BSD-like systems, should not we just exclude > those systems instead of enabling solely Linux? > {code} > Assume.assumeFalse("Avoiding JDK-8047340 on BSD-based systems", Shell.FREEBSD > || Shell.MAC); > {code} > However, I don't think this is the right fix. Shell on BSD-like systems is > broken with the TR locale. Shell class initialization happens only because > StringUtils references Shell.WINDOWS. > We can simply catch Throwable in Shell#isSetsidSupported instead of > IOException. If we want to be pedantic we can rethrow > {code} > if (!(t instanceof IOException) && !(Shell.FREEBSD || Shell.MAC)) > {code} > With such a change the test can run unchanged. > {quote} -- This message was sent by Atlassian JIRA (v6.3.4#6332)