[ 
https://issues.apache.org/jira/browse/HADOOP-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572521#comment-14572521
 ] 

Vinayakumar B commented on HADOOP-8320:
---------------------------------------


[~vijaysbhat], thanks for the update on patch.

Two things need to be corrected.

# AbstractFileSystem doesn't support relative paths, Instead it supports only 
fully qualified or paths starting with root '/'. Its okay untill relative path 
is corrected already in FileContext before passing to AFS.

# Usage of {{NetUtils.getCanonicalUri(uri, getDefaultPort());}} was 
intentionally not done, because there was no need of DNS replacement for the 
host, which might be time consuming,  instead just needed to replace default 
port. Check javadoc in {{FileSystem#canonicalizeUri()}}

> FileSystem#checkPath and AbstractFileSystem#checkPath should share code
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-8320
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8320
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Vijay Bhat
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-8320.001.patch, HADOOP-8320.002.patch, 
> HADOOP-8320.003.patch, HADOOP-8320.004.patch, HADOOP-8320.005.patch, 
> HADOOP-8320.007.patch
>
>
> Per the discussion on HADOOP-8310, these two methods can be refactored to 
> share some code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to